refactor: apply code review feedback to getCitationFieldsInputArray#6739
Merged
louis-bompart merged 3 commits intofix/KIT-5305from Dec 8, 2025
Merged
refactor: apply code review feedback to getCitationFieldsInputArray#6739louis-bompart merged 3 commits intofix/KIT-5305from
louis-bompart merged 3 commits intofix/KIT-5305from
Conversation
Co-authored-by: louis-bompart <12366410+louis-bompart@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix support for normalized JSON array in attribute input
refactor: apply code review feedback to getCitationFieldsInputArray
Dec 8, 2025
louis-bompart
approved these changes
Dec 8, 2025
packages/atomic/src/components/search/atomic-generated-answer/atomic-generated-answer.tsx
Outdated
Show resolved
Hide resolved
…atomic-generated-answer.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses code review comments from PR #6738 to improve type safety, syntax, and logic in the
getCitationFieldsInputArray()method.Changes
string[]) togetCitationFieldsInputArray()for type safetyifkeyword, added missing semicolon after.split(',')undefined)Before
After
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.